feat: Add a JSON Block definition interface#9613
feat: Add a JSON Block definition interface#9613heliacer wants to merge 1 commit intoRaspberryPiFoundation:mainfrom
Conversation
|
hi, I noticed the review assignment changed, |
maribethb
left a comment
There was a problem hiding this comment.
Thank you so much for your patience while we reviewed this. This needed some consultation from our resident TS expert and after chatting with him I think we want to go in a different direction for custom fields for now. But the rest of this is mostly solid, thank you for your work on it.
packages/blockly/tests/typescript/src/field/json_block_custom_args.ts
Outdated
Show resolved
Hide resolved
16361e8 to
def8672
Compare
|
hi @maribethb, for the custom fields (and inputs), I provided an interface UnknownArg {
type: string
[key: string]: unknown
}this preserves existing typings, so intellisense continues to work as expected. Thanks :D & Have a good day |
This is a follow-up of #9402 :D (please read)
Changes:
tests/typescriptfor field mitosisThe custom fields are done by augmenting, as shown in the jsdoc example.
Also I'm not too proud of the documentation strings in general but I'm leaving it as-is now.
lmk if I need to change something in order to merge :>